Skip to content

Document approval process and group #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/APPROVERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# The Approvers Group

A vital role in our project is reserved for the people who decide what code is accepted into our framework, and what
is not. This is the task of the (Git) Approvers Group. To explain let's look at how the code of DNN gets changed.

As you are probably aware the way the source code of DNN (which is hosted on Github)
is currently managed, is through accepting so-called Pull Requests (or PRs). These PRs are submitted by
enthusiasts like you and me where we aim to change the Repository ("base code") of the platform. The current list
of PRs can be found here: [https://github.com/dnnsoftware/Dnn.Platform/pulls](https://github.com/dnnsoftware/Dnn.Platform/pulls)

Before any PR gets accepted it has to be reviewed by 2 people before it can be "merged" into the main repository.
This reviewing and merging is done by a handful of people.
Due to the sensitive nature of this task and the skills required to do it, this is a highly restricted group.
In the interest of transparency and to avoid any confusion here is a list of criteria that guide our decision as to who is part of this group:

- Actively take part in the project (like attending Tech meetings, contributing code, etc)
- Having in-depth knowledge of the overall organization and architecture of the project (this favors people who have been with the project for some time)
- Having a track record of good code contributions
- Knowledge of Git and Github
- Having enough time to devote to this task

This group is dynamic. Meaning: we expect people to float into and out of this group.
It is not an award that you put on a shelf like an MVP-ship.
It is an ongoing task and if someone drifts away to focus on something else that person will be removed from this group.

This group is practical. Meaning: there are no stacks of procedures.
We try to keep things simple and focus on a smooth development process for DNN.
Members stay in touch through a Slack channel and meet
bi-weekly to discuss progress.

The current members are:
- Brian Dukes
- Peter Donker
- Mitch Sellers
- David Poindexter
- Daniel Valadas
- Matt Rutledge

4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ In addition to robust content management, the free, open source DNN Platform inc

* Single installation with multi-site capability
* File and folder management
* Static and dynamic Localization - 6 languages out-of-the-box (English, Ducth, French, German, Italian, and Spanish)
* Static and dynamic Localization - 6 languages out-of-the-box (English, Dutch, French, German, Italian, and Spanish)
* Customized web site templates and themes
* Cloud-ready with MS Azure compatibility
* 100's of REST API for site and content managment
Expand Down Expand Up @@ -47,6 +47,8 @@ All the details on contributing with Git and on our working methods can be found

In addition, since DNN is part of the .NET Foundation, we require our contributors to abide by their [Code of Conduct](https://www.dotnetfoundation.org/code-of-conduct) rules and requirements also.

Pull requests are reviewed and accepted by the Approvers Group. Read more about the process and this group here: [Approvers](.github/APPROVERS.md)

## .NET Foundation

This project is supported by the [.NET Foundation](https://dotnetfoundation.org).
Expand Down