Move email above username field. #3204
Conversation
thabaum
changed the title
|
IMO it would be best, if the order is confgurable by admins without limit |
|
I didnt change "Username" position. I changed Email Address, username is still above email address. And it would be nice to have the option to be able to move things around, but this makes the form look right as Mitchel pointed out a while back on my site that the order was wrong so I made this pull request. I was thinking it might get dealt by someone else that might notice the same issue but never has. I am just hoping I did it right... :) And if someone can one up this pull request please be my guest just trying to help the next person... "Logic is the beginning of wisdom; not the end." -- Spock (Star Trek VI) |
Yes, I totally agree and it looks like it would take breaking the BIO fields down as well to allow adding/removing those and putting them in an order that works best for the website purpose. Some pretty dynamic code from what is currently present. I am interested in taking on this task potentially down the road if it does not get done. I am just too swamped for past few years now... Maybe we can work on this together I would really love to understand all the pieces to DNN so I can make some better pull requests in the future that might raise an eyebrow... |
|
For clarity this pull request changes things to this order: Username, Email, Password, Verify Password, Bio, Terms, Submit, authentication, sign in. The previous way had Email after Password. This pull request puts Email on top of the password. https://www.template.net/web-templates/htmlcss-templates/signup-form/ Here are 20+ HTML5 examples that I believe would be nice to get the login to look like one of these two IMO I like the look and feel of this one and there are about 5 other ones I like but regardlesss they are all pretty much setup like how I put this pull request together. |
There was a problem hiding this comment.
IMHO I think that the proper order for this, if we change it should be
- Username
- Password
- Confirm Password.
This follows the industry standard of keeping username next to password. If email as username is selected then it would just be
- Password
- Confirm Password
|
I can make this change. I only seen one other form that worked like this, but really it is to satisfy keeping the email and username above the password so I really do not care which way it goes. I was just looking at the way most did it but I do like email on top as that was my preference originally prior to researching... |
Moved email above username field.
To discuss this a little further can anyone give me a heads up on what to expect to make this happen if you coded it and I will give it a shot... it would be a good way to get my feet a little wetter here and build some confidence. I figure a few things need to be thought about which is the db schema, sp's and admin ui plus back end code. I am still getting used to github and the new tools along with the latest best practices and future but I am ready to fly soon I believe. I should be able to do this in github overtime with help :) Maybe show me a proper way to open this up as a discussion issue and I will take some notes from it as far as what details to include and presentation. I tend to be long winded. I can then use this as a template and try to tackle this task with a solution that works. It would really help me understand how everything needs to be connected and written. Of coarse someone else could definitely take this on and I can work on something else if there is someone that can whip this out in the best logical way please do. It would be awesome! I think I could create "something" by version 10 release candidates possibly with some help. |
Website/controls/user.ascx
Outdated
| @@ -20,6 +20,17 @@ | |||
| <asp:requiredfieldvalidator id="valLastName" runat="server" cssclass="NormalRed" display="Dynamic" errormessage="<br>Last Name Is Required." | |||
| controltovalidate="txtLastName" resourcekey="valLastName"></asp:requiredfieldvalidator></td> | |||
| </tr> | |||
| </tr> | |||
|
Thanks @thabaum , nothing major here, but next time, we like to have an issue before a pull request and a link back to it in the issue comments (like |
bdukes
changed the title
|
Thank you for the pointers @valadas @bdukes @david-poindexter @mitchelsellers and everyone helping me get my first PR through GitHub and DNN CE. I had to figure out to re-request reviews and it seemed like I had to hit a refresh icon for david to re-review which I spent time looking for. I am also trying to understand the branches better so I can keep fixes and issues separate. I will play with this more takes time which I am short on but really wanting to dig in here and help. I will watch your video tutorials again refresh things as I want to +1 this PR soon hopefully. Thanks again for accepting my first PR! 👍 |
this current issue in GitHub could use some support... this is what I am trying to figure out and find easily how to create an issue and then create a branch. And I wish to understand what is done on my fork as far as development version and how everyone gets to play with it. I also see an option to delete fork below this message area. Not going to touch it since I don't know why it is there yet.
|
Update user.ascx to change order of fields for user registration (dnnsoftware#3204)
Summary
Email address is at the bottom below password. when you have to enter in the captcha code you have to scroll up to get to enter password again. would be nice not to have to re-enter passwords as this is an issue as well but at least the email address is below the username field with this pull request if accepted.
NOTE: I wish I could move "Display Name" below User Name but this is where the bio registration fields go so no way to really move this easily.
If you have Email as Username set the email address is at the bottom making a user enter passwords first and I can't find any other website that does this. However email address under Username is more industry standard I believe for a registration form.