Skip to content

Fix exception loading JS library #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Sep 16, 2019

This exception is occurring on sites upgraded to DNN 9.4.0 when opening module settings, because the DnnComboBox class in use on module settings loads the Selectize library, which will now have two versions installed.

Fixes #2993

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valadas valadas added this to the 9.4.1 milestone Sep 17, 2019
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@valadas valadas merged commit e85dad2 into release/9.4.x Sep 18, 2019
@valadas valadas deleted the bug/module-settings-exception branch December 31, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants