DNN-21290: Import/Export Circular Dependency in pages cause pages not… #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current implementation is to check for parent recursively, by iterating through each tab either by checking its parent id or its tab-type |
|
Here is the successful results from a manually queued build of the DNN[CI] vsts task. https://dotnetfoundation.visualstudio.com/DNN/_build/results?buildId=3843&_a=summary |
mitchelsellers
approved these changes
Aug 14, 2018
ohine
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #2172
This has been verified to work in client's patched 9.2.0 installation.
@Mohtshum if possible, please share any helpful insight about implementation details.