Skip to content

Enhancement remove sharing on x #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enhancement remove sharing on x #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c252fc2
Update Twitter link to Bluesky in footer
leewyatt Mar 16, 2025
7d9192e
Remove unused FooterView action properties
leewyatt Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 4 additions & 119 deletions components/src/main/java/com/dlsc/jfxcentral2/components/FooterView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import com.dlsc.jfxcentral2.model.Size;
import com.dlsc.jfxcentral2.utils.ExternalLinkUtil;
import com.dlsc.jfxcentral2.utils.PagePath;
import javafx.beans.property.ObjectProperty;
import javafx.beans.property.SimpleObjectProperty;
import javafx.geometry.HPos;
import javafx.geometry.Pos;
import javafx.geometry.VPos;
Expand Down Expand Up @@ -85,9 +83,9 @@ private LineNumberPane initLegalInfoPane() {
}

private LineNumberPane initLinksPane() {
Hyperlink twitterLink = new Hyperlink("Twitter");
twitterLink.getStyleClass().addAll("link", "twitter-link");
ExternalLinkUtil.setExternalLink(twitterLink, "https://twitter.com/dlemmermann");
Hyperlink blueskyLink = new Hyperlink("Bluesky");
blueskyLink.getStyleClass().addAll("link", "bluesky-link");
ExternalLinkUtil.setExternalLink(blueskyLink, "https://bsky.app/profile/dlemmermann.bsky.social");

Hyperlink linkedinLink = new Hyperlink("Linkedin");
linkedinLink.getStyleClass().addAll("link", "linkedin-link");
Expand All @@ -101,7 +99,7 @@ private LineNumberPane initLinksPane() {
youtubeLink.getStyleClass().addAll("link", "youtube-link");
ExternalLinkUtil.setExternalLink(youtubeLink, "https://www.youtube.com/@dlsc/videos");

LineNumberPane linksPane = new LineNumberPane(new Label("Stay in the loop"), null, twitterLink, linkedinLink, githubLink, youtubeLink);
LineNumberPane linksPane = new LineNumberPane(new Label("Stay in the loop"), null, blueskyLink, linkedinLink, githubLink, youtubeLink);
linksPane.getStyleClass().add("links-pane");
return linksPane;
}
Expand Down Expand Up @@ -138,7 +136,6 @@ private LineNumberPane initContactPane() {
return contactPane;
}


private static class LineNumberPane extends GridPane {

public LineNumberPane(Node... nodes ) {
Expand Down Expand Up @@ -170,116 +167,4 @@ public LineNumberPane(Node... nodes ) {
}
}
}

private final ObjectProperty<Runnable> onSendMail = new SimpleObjectProperty<>(this, "onSendMail");

public Runnable getOnSendMail() {
return onSendMail.get();
}

public ObjectProperty<Runnable> onSendMailProperty() {
return onSendMail;
}

public void setOnSendMail(Runnable onSendMail) {
this.onSendMail.set(onSendMail);
}

private final ObjectProperty<Runnable> onCookies = new SimpleObjectProperty<>(this, "onCookies");

public Runnable getOnCookies() {
return onCookies.get();
}

public ObjectProperty<Runnable> onCookiesProperty() {
return onCookies;
}

public void setOnCookies(Runnable onCookies) {
this.onCookies.set(onCookies);
}

private final ObjectProperty<Runnable> onTwitter = new SimpleObjectProperty<>(this, "onTwitter");

public Runnable getOnTwitter() {
return onTwitter.get();
}

public ObjectProperty<Runnable> onTwitterProperty() {
return onTwitter;
}

public void setOnTwitter(Runnable onTwitter) {
this.onTwitter.set(onTwitter);
}

private final ObjectProperty<Runnable> onLinkedin = new SimpleObjectProperty<>(this, "onLinkedin");

public Runnable getOnLinkedin() {
return onLinkedin.get();
}

public ObjectProperty<Runnable> onLinkedinProperty() {
return onLinkedin;
}

public void setOnLinkedin(Runnable onLinkedin) {
this.onLinkedin.set(onLinkedin);
}

private final ObjectProperty<Runnable> onGithub = new SimpleObjectProperty<>(this, "onGithub");

public Runnable getOnGithub() {
return onGithub.get();
}

public ObjectProperty<Runnable> onGithubProperty() {
return onGithub;
}

public void setOnGithub(Runnable onGithub) {
this.onGithub.set(onGithub);
}

private final ObjectProperty<Runnable> onYoutube = new SimpleObjectProperty<>(this, "onYoutube");

public Runnable getOnYoutube() {
return onYoutube.get();
}

public ObjectProperty<Runnable> onYoutubeProperty() {
return onYoutube;
}

public void setOnYoutube(Runnable onYoutube) {
this.onYoutube.set(onYoutube);
}

private final ObjectProperty<Runnable> onTC = new SimpleObjectProperty<>(this, "onTC");

public Runnable getOnTC() {
return onTC.get();
}

public ObjectProperty<Runnable> onTCProperty() {
return onTC;
}

public void setOnTC(Runnable onTC) {
this.onTC.set(onTC);
}

private final ObjectProperty<Runnable> onPrivacyPolicy = new SimpleObjectProperty<>(this, "onPrivacyPolicy");

public Runnable getOnPrivacyPolicy() {
return onPrivacyPolicy.get();
}

public ObjectProperty<Runnable> onPrivacyPolicyProperty() {
return onPrivacyPolicy;
}

public void setOnPrivacyPolicy(Runnable onPrivacyPolicy) {
this.onPrivacyPolicy.set(onPrivacyPolicy);
}
}
2 changes: 1 addition & 1 deletion components/src/main/resources/com/dlsc/jfxcentral2/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@
-fx-spacing: 40px;
}

.footer-view .links-pane .twitter-link {
.footer-view .links-pane .bluesky-link {
tf: -blue;
-fx-text-fill: tf;
}
Expand Down
8 changes: 0 additions & 8 deletions sampler/src/main/java/com/dlsc/jfxcentral2/demo/components/HelloFooterView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ public String getSampleName() {
@Override
protected Region createControl() {
footer = new FooterView();
footer.setOnSendMail(() -> System.out.println("Send mail to [email protected]"));
footer.setOnTwitter(() -> System.out.println("https://twitter.com/dlemmermann"));
footer.setOnGithub(() -> System.out.println("https://github.com/dlsc-software-consulting-gmbh"));
footer.setOnLinkedin(() -> System.out.println("https://www.linkedin.com/in/dlemmermann/"));
footer.setOnYoutube(() -> System.out.println("youtube channel"));
footer.setOnTC(() -> System.out.println("onT&C"));
footer.setOnPrivacyPolicy(() -> System.out.println("onPrivacyPolicy"));
footer.setOnCookies(() -> System.out.println("onCookies"));
return new ScrollPane(footer);
}

Expand Down