Skip to content

Fixing auth provider without authenticator error #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Dec 21, 2020

If there were providers without an authenticator (e.g. validator only), this would route to the landing page

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #48 (1be9945) into main (5b11ced) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   43.29%   43.22%   -0.07%     
==========================================
  Files          29       29              
  Lines        1349     1351       +2     
==========================================
  Hits          584      584              
- Misses        765      767       +2     
Flag Coverage Δ
tests 43.22% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fastapi_aad_auth/ui/__init__.py 18.18% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b11ced...1be9945. Read the comment docs.

@github-actions github-actions bot added the fix label Dec 21, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djpugh djpugh merged commit 79bf0f7 into main Dec 21, 2020
@djpugh djpugh deleted the fix/provider-without-authenticator-token-auto-auth branch December 21, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant