skip to main #2054
Open
skip to main #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a comment to add a co-author Co-authored-by: Howard Cox <[email protected]>
sabderemane
reviewed
Apr 27, 2025
djangoproject/templates/base.html
Outdated
| @@ -86,6 +87,7 @@ | |||
| </ul> | |||
| {% endif %} | |||
| {% endblock %} | |||
| <div id="main-content"></div> | |||
There was a problem hiding this comment.
Could we add the id on the main tag instead? This will avoid adding a new tag, especially a div only for that and the messages will be visible.
|
Possibly relates to #1367 |
|
Hi @moshe742, do you have still time to work on this one? |
|
@moshe742 Could you address the comments on this PR if you're still interested in working on it? Otherwise it will be closed in a week. Thanks! |
|
Sorry for not responding for this long, I am still available for work on this. |
marksweb
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.