-
Notifications
You must be signed in to change notification settings - Fork 55
Algorithms for Crossing Numbers #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@MarkToner looks like there's lots of good stuff in this PR, can you please fix the linting issues, and then we will give this a proper review? Thanks! |
@james-d-mitchell Will do as soon as soon as possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see a few changes that you must have committed by accident, which seem to be preventing tests from passing. Take a look at the lines I've commented on, and probably just revert them. That might get the last tests passing.
Added functionality for computing the crossing number of digraphs, both actual values and upper and lower bounds.
Also added miscellaneous functionality to support this goal:
All functionality has been tested, with all public-facing functionality documented.