docr: Update RegistriesService to add all the methods which makes it self-sufficient for all registries operations #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…self-sufficient for all registries operations. Note that except for List, Get, Delete and DockerCredentials, all the method definitions would remain the same between the old and the new service. We decided to just duplicate the code and not go for an abstraction as it was making it unnecessarily complicated, especially because RegistryService is getting deprecated and will eventually be removed. When that happens, it will also be easier to just remove RegistryService code instead of untagling it out of an abstraction.
rak16
changed the title
loosla
previously approved these changes
Apr 25, 2025
loosla
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides adding the full set of methods on
RegistriesService, I have made changes toRegistries.Createand it now functions the same wayRegistry.Createdoes.