Update kubernetes dependencies to 1.21.1 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottwald
reviewed
Jun 21, 2021
go.mod
Outdated
| k8s.io/metrics => k8s.io/metrics v0.20.2 | ||
| k8s.io/api => k8s.io/api v0.21.1 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.21.1 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.21.2-rc.0 |
There was a problem hiding this comment.
Is there a reason to use an rc release here? v0.21.2 would also be available. Also applies to the other rcs in this file.
There was a problem hiding this comment.
Probably the same reason as in #318 (comment).
There was a problem hiding this comment.
Seems like it. v0.21.1 and v0.21.2-rc.0 both point to 7559d78
There was a problem hiding this comment.
Aha, I wondered about this as well but trusted that the tool was calculating things correctly. Updated to v0.21.1 everywhere for consistency.
As part of this change, use the resizefs implementation from `k8s.io/mount-utils`. This gets rid of the last reference to `k8s.io/kubernetes`, so we no longer need to vendor it 🎉. While we're here, tidy up the go.mod file a bit by putting all the `replace`s in one stanza. I suspect we ended up with some separated out at the end via previous runs of update-k8s.sh, but I don't see any good reason to keep it that way.
timoreimann
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, use the resizefs implementation from
k8s.io/mount-utils. This gets rid of the last reference tok8s.io/kubernetes, so we no longer need to vendor it 🎉.While we're here, tidy up the go.mod file a bit by putting all the
replaces in one stanza. I suspect we ended up with some separated out at the end via previous runs of update-k8s.sh, but I don't see any good reason to keep it that way.