Fix and improve logging #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
reviewed
Dec 16, 2019
snormore
approved these changes
Dec 16, 2019
added 2 commits
December 17, 2019 01:08
This change applies a number of improvements to the way we log: - Rename "node_id" field set on controller initialization to "host_id" to avoid confusion with the "node_id" we set in various gRPC endpoint implementations: the former specifies we host we run on while the latter refers to the node ID passed in from the request. The two may diverge, especially on the controller. - Pass existing logrus entry to waitAction to expand fields on. - Log methods called and returned more consistently.
timoreimann
force-pushed
the
fix-and-improve-logging
branch
from
b03fd9d to
85222ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies a number of improvements to the way we log:
waitActionto expand fields on.llto the more readablelog.