Skip to content

Use WARN log level for non-critical failures to get an action #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## unreleased

* Use WARN log level for non-critical failures to get an action
[[GH-241]](https://github.com/digitalocean/csi-digitalocean/pull/241)
* Reject requests for block access type
[[GH-225]](https://github.com/digitalocean/csi-digitalocean/pull/225)
* Assume detached state on 404 during ControllerUnpublishVolume
Expand Down
2 changes: 1 addition & 1 deletion driver/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ func (d *Driver) waitAction(ctx context.Context, volumeId string, actionId int)
if err != nil {
ctxCanceled := ctx.Err() != nil
if !ctxCanceled {
ll.WithError(err).Info("getting action for volume")
ll.WithError(err).Warn("getting action for volume")
return false, nil
}

Expand Down