Implement graceful shutdown #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
implement-graceful-shutdown
branch
from
b144430 to
8a4c5f8
Compare
adamwg
approved these changes
Dec 17, 2019
driver/driver_test.go
Outdated
|
|
||
| go func() { | ||
| err := driver.Run(ctx) | ||
| if err != nil { |
There was a problem hiding this comment.
If we want to check this error reliably, we should probably call cancel after sanity.Test returns, and use a WaitGroup or channel to wait for this goroutine to shut down before the test ends. As it's written currently, I suspect the test will be finished before this line is executed, since the defer will execute right at the end of the test function.
There was a problem hiding this comment.
Ah, good catch.
I went with an errgroup. Let me know if that makes sense to you.
added 2 commits
December 18, 2019 00:01
This change implements graceful shutdown so that a proper driver termination leads to an exit code of zero. Specifically, we handle signals, and let the HTTP and gRPC servers finish requests gracefully. We also remove the Stop() function in favor a context-based approach.
timoreimann
force-pushed
the
implement-graceful-shutdown
branch
from
a541000 to
e2328c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements graceful shutdown so that a proper driver termination leads to an exit code of zero.
Specifically, we handle signals, and let the HTTP and gRPC servers finish requests gracefully.
We also remove the
Stop()function in favor a context-based approach.