Skip to content

csi: v1.0.0 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2018
Merged

csi: v1.0.0 #113

merged 4 commits into from
Dec 19, 2018

Conversation

fatih
Copy link
Contributor

@fatih fatih commented Dec 3, 2018

CSI v1.0.0 is released (\o/): https://github.com/container-storage-interface/spec/releases/tag/v1.0.0.

This is only compatible with Kubernetes v1.13+. With that, there were
many changes and updates so this PR combines all these changes:

  • Updated all sidecars to support the new spec
  • Update plugin registry dir from /var/lib/kubelet/plugins/ to /var/lib/kubelet/plugins_registry/
  • Updated the dependencies to comply with the latest CSI version, such as github.com/golang/protobuf to v1.2.0

@fatih
Copy link
Contributor Author

fatih commented Dec 3, 2018

Snapshots integration tests are not working for some reasons, looking into it.

@@ -435,7 +434,7 @@ spec:
hostNetwork: true
containers:
- name: driver-registrar
image: quay.io/k8scsi/driver-registrar:v0.4.1
image: quay.io/k8scsi/driver-registrar:v1.0-canary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the new node-driver-registrar here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that it seems like we should use node-driver-registrar since driver-registrar is deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, as I said this was splitted and needs to be changed. However, I"m waiting for the documentation on how to implement and add both the cluster- and node- driver registrars. The relevant PR that adds the instructions will be added today or tomorrow to the CSI documentation repo.

@joonas
Copy link
Contributor

joonas commented Dec 18, 2018

Should we consider also adding cluster-driver-registrar?

@@ -435,7 +434,7 @@ spec:
hostNetwork: true
containers:
- name: driver-registrar
image: quay.io/k8scsi/driver-registrar:v0.4.1
image: quay.io/k8scsi/driver-registrar:v1.0-canary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that it seems like we should use node-driver-registrar since driver-registrar is deprecated.

CSI v1.0.0 is released (\o/): https://github.com/container-storage-interface/spec/releases/tag/v1.0.0.

With that, there were many changes and updates so this PR combines all
these changes.

* Create a default `VolumeSnapshotClass` so people don't have to define
them when they use DO for their snapshotting needs.
* Add new `csi-snapshotter` sidecar that is responsible of calling the
three CSI methods we implemented: `ListSnapshots`, `CreateSnapshot` and
`DeleteSnapshot`. In addition to this, the `csi-snapshotter` sidecar is
also responsible of creating the `VolumeSnapshotClasss` CRD
* Updated sidecars to the newest and latest
* Added back the ClusterRole's for each sidecar. Kubernetes no more
carries them and it's up to the sidecars to provider them to the users.
@fatih fatih merged commit 6a16448 into master Dec 19, 2018
@fatih fatih deleted the csi-v1.0.0 branch December 19, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants