Make http headers case-insensitive #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was running into an issue where I was trying to set the content-type header to x-www-form-urlencoded, but VRC was sending TWO content-type headers, one with my value, and one with type json.
It looks like internally the default content-type is json and is set with the key "Content-Type". When I set the "content-type" header, the default wasn't being overridden because it uses a different case.
This PR makes all http headers lowercase upon processing so that you can't send multiple of the same header. Note that http headers are case-insensitive in the spec. https://stackoverflow.com/a/5259004