Skip to content

feat(localization): NO-JIRA merge i18n base branch #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: staging
Choose a base branch
from
Open

feat(localization): NO-JIRA merge i18n base branch #785

wants to merge 26 commits into from

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Jun 3, 2025 •
edited
Loading

Merge i18n base branch

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Description

  • Merge i18n base branch into staging (Individual PR's have already been approved)

💡 Context

Localization work on Dialtone vue 2 is finished, we're merging it into staging as it doesn't have any breaking change.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

🔮 Next Steps

  • Migrate to Vue 3

@juliodialpad
feat(localization): DLT-2461 refactor components (#724)
1a01493 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
feat(localization): DLT-2461 refactor components (part 2) (#731)
34137b9 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
14d675e 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
b0b4c0d
@juliodialpad
refactor(localization): DLT-2515 refactor components - part3 (#757)
78b1695 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
07a4348
@juliodialpad
refactor(localization): DLT-2517 refactor recipes - part1 (#763)
20789f2 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
refactor(localization): DLT-2518 refactor recipes - part 2 (#769)
321a6ba 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
bc9edba
@juliodialpad
refactor(localization): refactor using singleton pattern (#776)
9ee3722 
Signed-off-by: Julio Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
543e11a 
Signed-off-by: Tico Ortega <[email protected]>

# Conflicts:
#	packages/dialtone-vue2/components/emoji_picker/emoji_picker.stories.js
#	packages/dialtone-vue2/components/emoji_picker/emoji_picker.test.js
#	packages/dialtone-vue2/components/emoji_picker/emoji_picker.vue
#	packages/dialtone-vue2/components/emoji_picker/emoji_picker_constants.js
#	packages/dialtone-vue2/components/emoji_picker/emoji_picker_default.story.vue
#	packages/dialtone-vue2/components/emoji_picker/modules/emoji_tabset.vue
#	packages/dialtone-vue2/recipes/conversation_view/message_input/message_input.stories.js
@juliodialpad
update keywords
8433320 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
a454227
@juliodialpad
extract common function
05badb2 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
fix currentLocale on datepicker
7be4f78 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
fix missing i18n prefix
f45f5cf 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
update comments
e4dde0c 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
undo settings_menu_button refactor to avoid breaking changes
29cb386 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
update i18n dependency versions
a853854 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
remove sync-icons from build
35d3277 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
uncomment localization entry points
46d76ae 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
cleanup
0c8164b 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
Merge branch 'staging' into i18n/base-branch
6dcd7fb 
# Conflicts:
#	package.json
@juliodialpad
add ariaLabel back into icon
1f4a514 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
add missing dependency install documentation
dc2dfaa 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad
docs(localization): add documentation (#784)
4b290a4 
Signed-off-by: Tico Ortega <[email protected]>
@juliodialpad juliodialpad self-assigned this Jun 3, 2025
@juliodialpad juliodialpad requested a review from ninamarina as a code owner June 3, 2025 20:55
@juliodialpad juliodialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Jun 3, 2025
@juliodialpad juliodialpad changed the title feat(localization): NO-JIRA Merge i18n base branch feat(localization): NO-JIRA merge i18n base branch Jun 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-785/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-785/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-785/

braddialpad
braddialpad approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to review this since the majority of it has already been reviewed and it would be impossible to pick out whats changed.

Lets just make sure we don't get i18n dependency permission issues as those are frustrating a lot of people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@juliodialpad juliodialpad

Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @braddialpad