[VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatic route commands
volodymyrsamotiy
approved these changes
Aug 25, 2022
dgsudharsan
pushed a commit
that referenced
this pull request
Feb 8, 2024
…decimal (sonic-net#3153) * Fix the sfputil treats page number as decimal instead of hexadecimal (#22) Fix the sfputil treats page number as decimal instead of hexadecimal Signed-off-by: Kebo Liu <[email protected]> * remove unreachable code Signed-off-by: Kebo Liu <[email protected]> --------- Signed-off-by: Kebo Liu <[email protected]>
dgsudharsan
pushed a commit
that referenced
this pull request
Feb 27, 2024
…onic-net#3153) * Fix the sfputil treats page number as decimal instead of hexadecimal (#22) Fix the sfputil treats page number as decimal instead of hexadecimal Signed-off-by: Kebo Liu <[email protected]> * remove unreachable code Signed-off-by: Kebo Liu <[email protected]> --------- Signed-off-by: Kebo Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added CLI checks to verify if Vrf is created and valid when used in interface bind and static route commands
How I did it
Check for presence of Vrf in VRF table or in case if it is mgmt vrf, verify if mgmt vrf is enabled/
How to verify it
Added UT to verify it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)