[Mellanox]Fix lpmode set when logical port is larger than 64 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
approved these changes
Mar 7, 2023
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 21, 2023
fa8b709 Handled the error case of negative age (#57) 990f5b0 Use github code scanning instead of LGTM (#55) a7992c5 Install libyang for swss-common. (#50) 244fa86 Update README.md Signed-off-by: Vivek Reddy Karri <[email protected]>
dgsudharsan
pushed a commit
that referenced
this pull request
Apr 21, 2023
fa8b709 Handled the error case of negative age (#57) 990f5b0 Use github code scanning instead of LGTM (#55) a7992c5 Install libyang for swss-common. (#50) 244fa86 Update README.md Signed-off-by: Vivek Reddy <[email protected]>
dgsudharsan
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ly (sonic-net#21230) #### Why I did it src/dhcprelay ``` * b242307 - (HEAD -> master, origin/master, origin/HEAD) Revert "Fail build when test fail (#53)" (#62) (19 hours ago) [Yaqiang Zhu] * dbaee8b - Fail build when test fail (#53) (6 days ago) [Yaqiang Zhu] * ef7b972 - [Build] Update to build bookworm debian package (#55) (8 days ago) [Yaqiang Zhu] * 011066a - Add wait and check ip address check when dhcp6relay init (#52) (11 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 17, 2025
…lly (sonic-net#831) #### Why I did it src/sonic-swss ``` * 77503d9 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#55) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
May 12, 2025
…D automatically (sonic-net#1105) #### Why I did it src/sonic-sairedis ``` * 3c33c26 - (HEAD -> 202412, origin/HEAD, origin/202412) Update codeql runs-on ubuntu version to 22.04 (#56) (3 hours ago) [mssonicbld] * 87d6f46 - [trim]: Add Packet Trimming to VS lib (#55) (18 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
May 30, 2025
…ly (sonic-net#22595) #### Why I did it src/sonic-stp ``` * 33314fc - (HEAD -> master, origin/master, origin/HEAD) MSTP Feature - stpsync API changes (#55) (12 days ago) [Divya Kumaran Chandralekha] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In sfplpm API, the number of logical ports is hardcoded as 64. When a system contains more port than this, the SDK APIs would fail with a syslog as below
Mar 7 03:53:58.105980 r-leopard-58 ERR syncd#SDK: [MGMT_LIB.ERR] Slot [0] Module [0] has logport [0x00010069] in enabled state
Mar 7 03:53:58.105980 r-leopard-58 ERR syncd#SDK: [SDK_MGMT_LIB.ERR] Failed in __sdk_mgmt_phy_module_pwr_attr_set, error: Internal Error
Mar 7 03:53:58.106118 r-leopard-58 ERR pmon#-c: Error occurred when setting power mode for SFP module 0, slot 0, error code 1
How I did it
Remove the hardcoded value of 64. Obtained the number of logical ports from SDK
How to verify it
Manual testing
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)