feat: make dfx ledger work with local ledger installations #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables dfx to work with local ledger installations. `dfx ledger balance` and `dfx ledger transfer` now support `--ledger-canister-id` parameter. Examples: ```sh $ dfx ledger \ --network local \ balance \ --ledger-canister-id rrkah-fqaaa-aaaaa-aaaaq-cai 1000.00000000 ICP $ dfx ledger \ --network local \ transfer --amount 0.1 --memo 0 \ --ledger-canister-id rrkah-fqaaa-aaaaa-aaaaq-cai 8af54f1fa09faeca18d294e0787346264f9f1d6189ed20ff14f029a160b787e8 Transfer sent at block height: 1 ``` This change also improves error messages in `dfx ledger transfer`. The messages provide more context now.
ericswanson-dfinity
approved these changes
Feb 8, 2022
|
Oh, sorry, missed that conversation (don't get notifications from this repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables dfx to work with local ledger installations.
dfx ledger balanceanddfx ledger transfernow support--ledger-canister-idparameter.Examples:
This change also improves error messages in
dfx ledger transfer.The messages provide more context now.