Skip to content

fix: dfx cache list: skip cache directories being installed #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

ericswanson-dfinity
Copy link
Contributor

When dfx installs a cache directory, it first copies all of the files into a directory _<version>_<random>, and once all files have been copied, renames the directory to <version>. This prevents dfx from later using partially copied cache directories.

This change makes dfx cache list ignore these temporary directories, rather than exiting with an error message like unexpected character '_' while parsing major version number.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner January 15, 2022 00:08
@mergify mergify bot merged commit fd71bfb into master Jan 15, 2022
@mergify mergify bot deleted the cache-list branch January 15, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants