Skip to content

fix: oss-issues-on app detail page #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: oss-issues-on app detail page #5873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
011e92f
removed field image
RajeevRanjan27 Sep 19, 2024
ba9bc8b
Merge branch 'main' into fix-oss-issues
RajeevRanjan27 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/sql/repository/AppListingRepository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ func (impl AppListingRepositoryImpl) deploymentDetailsByAppIdAndEnvId(ctx contex
" env.cluster_id," +
" env.is_virtual_environment," +
" cl.cluster_name," +
" cia.image," +
" p.id as cd_pipeline_id," +
" p.ci_pipeline_id," +
" p.trigger_type" +
Expand All @@ -382,7 +381,6 @@ func (impl AppListingRepositoryImpl) deploymentDetailsByAppIdAndEnvId(ctx contex
}
deploymentDetail.EnvironmentId = envId

deploymentDetail.EnvironmentId = envId
dc, err := impl.deploymentConfigRepository.GetByAppIdAndEnvId(appId, envId)
if err != nil && err != pg.ErrNoRows {
impl.Logger.Errorw("error in getting deployment config by appId and envId", "appId", appId, "envId", envId, "err", err)
Expand Down
Loading