Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ServiceAccount Addition and Create ImagePullSecrets Function #5739

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

akshatsinha007
Copy link
Contributor

Copy link

gitguardian bot commented Aug 26, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4540226 Triggered Generic Password 2f58714 charts/devtron/values.yaml View secret
4540226 Triggered Generic Password a850712 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@akshatsinha007 akshatsinha007 merged commit 7b67ab8 into release-bot Aug 26, 2024
5 of 6 checks passed
@akshatsinha007 akshatsinha007 deleted the oss-chart-changes branch August 26, 2024 11:07
pawan-mehta-dt added a commit that referenced this pull request Sep 23, 2024
* Updated release-notes files

* Updated release notes

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of ci-runner in installer

* Updated latest image of image-scanner in installer

* Updated release-notes files

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated latest image of image-scanner in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of gitsensor in installer

* Updated latest image of notifier in installer

* Updated latest image of git-sensor in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of image-scanner in installer

* Updated latest image of image-scanner in installer

* Updated latest image of ci-runner in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of chart-sync in installer

* Updated release-notes files

* Updated latest image of image-scanner in installer

* Updated latest image of chart-sync in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of image-scanner in installer

* Updated latest image of hyperion in installer

* feat: ServiceAccount Addition and Create ImagePullSecrets Function (#5739)

* Updated function name

* imagepullSecre-for-chartsync

* Added Yamls of Scoop and Casbin

* Changes the default value of devtronEnterprise to false

* Changes the default value of devtronEnterprise to false

* Changes the default value of devtronEnterprise to false in bom

* handled the imagePullSecrets nil pointer error

* Updated function to handle nil pointer

* added passKey for scoop

* Updated latest image of dashboard in installer

* Updated latest image of kubewatch in installer

* Updated latest image of ci-runner in installer

* Updated latest image of devtron in installer

* Updated latest image of git-sensor in installer

* Updated latest image of lens in installer

* Updated latest image of kubelink in installer

* Updated latest image of image-scanner in installer

* Updated latest image of notifier in installer

* Update release.txt

* Updated latest image of hyperion in installer

* Update values.yaml

Updated Dashboard configmap-variables

* Update devtron.yaml

ConfigMap Variables

* Update devtron-bom.yaml

Dashboard-ConfigMap Changes

* Updated release-notes files

* Update workflow.yaml

Moved sevrice-account chart-sync and devtron-default-sa out of if statement

* Update configmap-secret.yaml

added  pre-upgrade upgrade hook to devtron-secret

* Update configmap-secret.yaml

reverted pre-upgrade hook from devtron-secret

* Updated release-notes files

* Update configmap-secret.yaml

Reverted ORCH_TOKEN changes

* Update casbin.yaml

* Update values.yaml

updated the GLOBAL_API_TIMEOUT: "60000"

* Update devtron-bom.yaml

updated the GLOBAL_API_TIMEOUT: "60000"

* Update casbin.yaml

* Update values.yaml

Removed resources from casbin

* Update devtron-bom.yaml

Removed casbin resources

* Update casbin.yaml

* Update values.yaml

Changed the user defined gitops flag to false.

* Update devtron-bom.yaml

* Updated latest image of devtron in installer

* Updated latest image of kubelink in installer

* Updated latest image of dashboard in installer

* Updated latest image of image-scanner in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of image-scanner in installer

* Update casbin.yaml

* Updated latest image of ci-runner in installer

* Updated Scoop-Config

* Updated latest image of devtron in installer

* Updated latest image of kubewatch in installer

* Updated latest image of kubelink in installer

* Updated latest image of git-sensor in installer

* Updated latest image of lens in installer

* Updated latest image of dashboard in installer

* Updated latest image of ci-runner in installer

* Updated latest image of chart-sync in installer

* Updated latest image of image-scanner in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated latest image of devtron in installer

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated release-notes files

* Updated latest image of devtron in installer

* updated nats port in nats-server.yaml and added INSTALLED_MODULES in devtron.yaml

* Updated latest image of kubewatch in installer

* Updated latest image of kubelink in installer

* Updated latest image of devtron in installer

* Updated latest image of git-sensor in installer

* Updated latest image of lens in installer

* Updated latest image of ci-runner in installer

* Updated latest image of notifier in installer

* Updated latest image of chart-sync in installer

* Updated latest image of image-scanner in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Updated latest image of dashboard in installer

* Update devtron.yaml

added CASBIN_CLIENT_URL in devtron-cm

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release-notes files

* Updated latest image of chart-sync in installer

* Updated release-notes files

* Updated latest image of kubewatch in installer

* Updated latest image of devtron in installer

* Updated latest image of kubelink in installer

* Updated release-notes files

* Updated latest image of notifier in installer

* Updated latest image of dashboard in installer

* Updated latest image of hyperion in installer

* Updated release-notes files

* Update casbin.yaml

* Update scoop.yaml

* Update releasenotes.md

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Update workflow.yaml

* Update update-release-notes.yml

* Update values.yaml

* Delete CHANGELOG/release-notes-v0.7.2.md

* Update values.yaml

* Update devtron-bom.yaml

* Update Chart.yaml

* Update releasenotes.md

bugs title modified

* Update releasenotes.md

modified Enhancements

* chore: removes enterprise feature listing of externalCi job

* Update devtron-bom.yaml

* Update values.yaml

* Update grafana.yaml

* Update minio.yaml

* Update migrator.yaml

* Update workflow.yaml

* Update devtron-installer.yaml

* Update installation-script

* Updated latest image of hyperion in installer

* Update values.yaml

* Update devtron-bom.yaml

* Update installation-script

* Update devtron-installer.yaml

* Update Chart.yaml

* Update devtron.yaml

* Update minio.yaml

* Update minio.yaml

* Updated release-notes files

* Update release-notes-v0.7.2.md

* Update releasenotes.md

* Update migrator.yaml

* Update nats-server.yaml

---------

Co-authored-by: ReleaseBot <[email protected]>
Co-authored-by: akshatsinha007 <[email protected]>
Co-authored-by: Pawan Mehta <[email protected]>
Co-authored-by: akshatsinha007 <[email protected]>
Co-authored-by: Vikram <[email protected]>
Co-authored-by: Abhibhaw Asthana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants