new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

yeyeto2788 · 2022-10-19T07:52:23Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

**This PR closes #789 **

Link to prove your SVG is correct and up-to-date.

Snailedlt

Those don't look like the official logos 🙊
Please change to the official ones (I linked to them in issue #789)

yeyeto2788 · 2022-10-20T07:17:19Z

That is really weird cuz I do see it correctly in Inkscape

Any suggestions on how to fix it? Maybe exporting it differently?

yeyeto2788 · 2022-10-20T07:19:08Z

I'll grouping them to see if that fixes the issue.

yeyeto2788 · 2022-10-20T07:25:22Z

I had to use the ones you provided on the issue itself as the grouping didn't work. Thanks for that!

lunatic-fox · 2022-10-22T22:48:18Z

Hello there!
@yeyeto2788 you're doing great!
I just have some recommendations to the icons.
First, I think you'll need to change the icons name and add two more icons:

original to original-wordmark
plain to plain-wordmark

And add the original and plain icons based on the square-like icon recommended by @Snailedlt on #789 issue.

To original-wordmark icon you can ungroup all and unify just "Jira Align" characters in one path.
To plain-wordmark icon, you can ungroup all and unify all in just one path.
All icons need to be an 128×128px square.

Wish for the best!

yeyeto2788 · 2022-10-24T08:41:22Z

Hey @lunatic-fox!

I think I have covered everything you asked me for but if you see there is something missing just let me know.

Best.

lunatic-fox · 2022-10-24T17:02:15Z

The icons look great now @yeyeto2788! 🤩

However there are some issues yet:

plain and plain-wordmark paths need to be united in just one path, to keep them as simple as possible.
Source doc: https://github.com/devicons/devicon/wiki/SVG-Standards
In devicon.json the icon color is #F04E98, I suggest #2684FF since is the main color of the original version.
You can add plain-wordmark to font array of versions object of devicon.json.
A recommendation is to ungroup all since you already fixed the invisible paths issue in your last icons.

Keep rocking! 🚀

yeyeto2788 · 2022-10-25T08:31:20Z

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

Ungroup the objects Ctrl Shift G
Select all Ctrl A
Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

lunatic-fox · 2022-10-25T14:59:54Z

Hello @yeyeto2788!
In short:

original ✔
original-wordmark ✔
plain ✔

But plain-wordmark is grouped. The key command to ungroup is Shift+Ctrl+G, otherwise it'll probably group instead. However, you can also follow that way bellow.

Checking layers

Go to Layers and Objects. If it's not opened you can open it by Object > Layers and Objects... or Shift+Ctrl+L
If you see some layer with , that means this layer is a group of layers.
You can ungroup this layer by right clicking on the layer and selecting Ungroup.
To be sure that everything is ungrouped, all layers should be with this icon
Once all layers are paths , them select all and Unify by Path > Union or Ctrl++
Lastly you should see just one path layer.

Hope everything works fine! 👍🏼

yeyeto2788 · 2022-10-26T09:32:39Z

Hopefully this one is the last one. Once again sorry for the inconveniences.

Best.

lunatic-fox · 2022-10-26T21:28:55Z

No worries! There is no inconvenience at all. 🙂
Like the other PR, I haven't seen before just two things: the altnames and tags properties are missing after name property.

Suggestions of tags

"tags": [
    "development",
    "integration",
    "software"
]

The icons are great now! 🎉

Like I said before you can also contact us on Discord server.

I also loved your idea of adding some instructions on using Inkscape!
I think this should be a feature request to the Wiki.

Snailedlt

Almost there! 🚀

Just need to add the name with whitespaces as an altname and minimize all of the icons. You can minimize the icons like I explained here: https://github.com/devicons/devicon/pull/1465/files#r1008766362

devicon.json

Snailedlt · 2022-10-29T23:06:21Z

@yeyeto2788

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

Ungroup the objects Ctrl Shift G

Select all Ctrl A

Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

lunatic-fox · 2022-10-29T23:17:10Z

@yeyeto2788

Hey @lunatic-fox!
I hope this time is correct. So for uniting the path I followed these steps:

Ungroup the objects Ctrl Shift G

Select all Ctrl A

Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

I'll be adding this later Instructions to resize to square and Checking layers.

Snailedlt · 2022-10-29T23:19:32Z

@lunatic-fox Nice! Please add links to those as comments with the same format I used in the issue I created: #1306

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

github-actions · 2022-10-31T16:11:35Z

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Snailedlt · 2022-10-31T16:22:31Z

Hi!

I'm the check-bot and we have some issues with your PR:
SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.
Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot 😄

@yeyeto2788 Please resize the viewbox as explained above. I recommend using iloveimg to make it fast and easy :)

github-actions · 2022-10-31T19:29:10Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

github-actions · 2022-10-31T19:54:42Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

github-actions · 2022-10-31T22:11:47Z

env.MESSAGE

Snailedlt

Looks good now, but the icons are still quite big. Could you please optimize them using this method? #1306 (comment)

yeyeto2788 · 2022-11-02T12:15:09Z

Looks good now, but the icons are still quite big. Could you please optimize them using this method? #1306 (comment)

I did that step before my last commit but I have done again hoping it does not screw anything as the last time.

Best.

github-actions · 2022-11-03T00:04:08Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

Looking good! ✔️
Thank you for your contribution! 💯

lunatic-fox

Approved! ✔
Great contribution! 🚀

…devicons#1468) * Add Jira Align icons * Fix logos * Fix minor issues discovered in PR. * Fix color for the icon and unite paths * Fix paths and ungroup objects. * Add altnames and tags to icon * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Minimize icons * Resize icon * Pass icons through SVGOMG Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Add Jira Align icons

cc87f65

Snailedlt requested changes Oct 19, 2022

View reviewed changes

Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 19, 2022

Fix logos

c0d8ae2

Fix minor issues discovered in PR.

78fe660

lunatic-fox mentioned this pull request Oct 24, 2022

new icon: p5js (original) #1465

Merged

6 tasks

Fix color for the icon and unite paths

436fd48

Fix paths and ungroup objects.

f158d5a

Add altnames and tags to icon

87cb13e

Snailedlt changed the title ~~new icon: Jira Align (original,plain)~~ new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) Oct 29, 2022

Snailedlt requested changes Oct 29, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Snailedlt mentioned this pull request Oct 29, 2022

[OTHER] Extending wiki with tutorials for each recommended tool #1306

Open

1 task

yeyeto2788 and others added 2 commits October 31, 2022 07:25

Update devicon.json

6eca745

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Minimize icons

1b89247

Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2022

Resize icon

34cf12b

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 31, 2022

Snailedlt requested changes Oct 31, 2022

View reviewed changes

Pass icons through SVGOMG

7cf87c3

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 3, 2022

Snailedlt approved these changes Nov 3, 2022

View reviewed changes

lunatic-fox approved these changes Nov 8, 2022

View reviewed changes

Snailedlt merged commit 73ddc75 into devicons:develop Nov 9, 2022

yeyeto2788 deleted the jiraalign branch March 7, 2023 09:03

Snailedlt mentioned this pull request Mar 7, 2023

new icon: pypi (original, original-wordmark, plain, plain-wordmark) #1697

Merged

6 tasks

canaleal mentioned this pull request Oct 24, 2023

New Icon: Forgejo (Original) #1926

Closed

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

yeyeto2788 commented Oct 19, 2022

Snailedlt left a comment •

edited

Loading

yeyeto2788 commented Oct 20, 2022

yeyeto2788 commented Oct 20, 2022

yeyeto2788 commented Oct 20, 2022

lunatic-fox commented Oct 22, 2022

yeyeto2788 commented Oct 24, 2022

lunatic-fox commented Oct 24, 2022

yeyeto2788 commented Oct 25, 2022

lunatic-fox commented Oct 25, 2022 •

edited

Loading

yeyeto2788 commented Oct 26, 2022

lunatic-fox commented Oct 26, 2022 •

edited

Loading

Snailedlt left a comment

Snailedlt commented Oct 29, 2022

lunatic-fox commented Oct 29, 2022

Snailedlt commented Oct 29, 2022

github-actions bot commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

Snailedlt left a comment

yeyeto2788 commented Nov 2, 2022

github-actions bot commented Nov 3, 2022

Snailedlt left a comment

lunatic-fox left a comment

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

Conversation

yeyeto2788 commented Oct 19, 2022

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Snailedlt left a comment • edited Loading

Choose a reason for hiding this comment

yeyeto2788 commented Oct 20, 2022

yeyeto2788 commented Oct 20, 2022

yeyeto2788 commented Oct 20, 2022

lunatic-fox commented Oct 22, 2022

yeyeto2788 commented Oct 24, 2022

lunatic-fox commented Oct 24, 2022

yeyeto2788 commented Oct 25, 2022

lunatic-fox commented Oct 25, 2022 • edited Loading

yeyeto2788 commented Oct 26, 2022

lunatic-fox commented Oct 26, 2022 • edited Loading

Snailedlt left a comment

Choose a reason for hiding this comment

Snailedlt commented Oct 29, 2022

lunatic-fox commented Oct 29, 2022

Snailedlt commented Oct 29, 2022

github-actions bot commented Oct 31, 2022

Snailedlt commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

github-actions bot commented Oct 31, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

yeyeto2788 commented Nov 2, 2022

github-actions bot commented Nov 3, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

lunatic-fox left a comment

Choose a reason for hiding this comment

Snailedlt left a comment •

edited

Loading

lunatic-fox commented Oct 25, 2022 •

edited

Loading

lunatic-fox commented Oct 26, 2022 •

edited

Loading