Skip to content

new icon: splunk (original-wordmark) #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 1, 2023
Merged

new icon: splunk (original-wordmark) #1433

merged 6 commits into from
Feb 1, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 7, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

closes #935

Link to prove your SVG is correct and up-to-date.

https://www.splunk.com/en_us/newsroom/media-kit.html
https://www.splunk.com/content/dam/splunk2/en_us/images/events/mediakit/splunk-corp-logo-k-rgb.png

@Snailedlt Snailedlt requested review from a team, Snailedlt and Panquesito7 and removed request for a team October 11, 2022 07:14
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 11, 2022
Panquesito7
Panquesito7 requested changes Oct 11, 2022
View reviewed changes
Snailedlt
Snailedlt requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the inconvenience and all of the back and forth :/

@weh @Snailedlt
Change color to #000
683c291 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 21, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@weh weh requested review from Snailedlt and Panquesito7 and removed request for Snailedlt and Panquesito7 October 26, 2022 07:30
Snailedlt
Snailedlt previously approved these changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for another great contribution!

@weh
Copy link
Contributor Author

weh commented Oct 31, 2022

@Panquesito7, your review would complete my fourth PR for hacktoberfest. If you can find some time, this would be very nice. (although it is a very minimalistic effort of mine)

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
@Snailedlt
Copy link
Collaborator

@Panquesito7, your review would complete my fourth PR for hacktoberfest. If you can find some time, this would be very nice. (although it is a very minimalistic effort of mine)

marked as hacktoberfest-accepted :)

@weh
Copy link
Contributor Author

weh commented Oct 31, 2022

thx @Snailedlt :)
Sadly this is one of my main motivations, to contribute every year, and the main reason i did not apply for a maintainer role.
Usually my contributions are very "seasonal", so i don't know how much i will help during the rest of the year.

@Snailedlt
Copy link
Collaborator

No worries @weh glad you're helping out as much as you are :)
Maintaining is absolutely optional, so no pressure.

Just in case this changes your mind though, we would still consider your application even if you are not super active

lunatic-fox
lunatic-fox requested changes Nov 8, 2022
View reviewed changes
@weh @lunatic-fox
Change to official color
3a1a87c 
Co-authored-by: Josélio Júnior <[email protected]>
Snailedlt
Snailedlt previously approved these changes Nov 10, 2022
View reviewed changes
@Snailedlt Snailedlt removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Nov 10, 2022
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Nov 10, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
lunatic-fox
lunatic-fox requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimize original-wordmark

lunatic-fox
lunatic-fox previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this contribution! 🚀

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt
Copy link
Collaborator

@Panquesito7 I see you have an old request changes review, but I assume we can dismiss it since the PR has fixed those issues now?

Panquesito7
Panquesito7 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

@Snailedlt Snailedlt merged commit a4aaf14 into devicons:develop Feb 1, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@weh @Snailedlt @lunatic-fox
new icon: splunk (original-wordmark) (devicons#1433)
44fd83e 
* Add icon: splunk (original-wordmark)

* Replaced color with suggestion

* Change color to #000

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Change to official color

Co-authored-by: Josélio Júnior <[email protected]>

* Update icons/splunk/splunk-original-wordmark.svg

Co-authored-by: Josélio Júnior <[email protected]>

* Remove extra line

---------

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox left review comments

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weh @Snailedlt @Panquesito7 @lunatic-fox