Real composer patches format #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Use the old patch file standard in drupal_tests, which was independent | ||
| // from any module composer.json patch specifications. | ||
| $patches_file = 'patches.json'; |
There was a problem hiding this comment.
👍 for this, we can remove it when Drupal 8.7 or 8.8 is out.
There was a problem hiding this comment.
Please take care. It follows only the default file name convention, not the old format. If the old/wrong composer patches format should be supported, we would need a different processing here.
templates/module/patches.json
Outdated
| } | ||
| } | ||
| } |
Not sure why this failed, as you haven't touched this file. I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my initial work on making drupal_tests compatible with the correct composer-patches format, like reported in #47 .
Includes changes:
patches-filein the modulepatches.jsonlike it was before, no matter if it was defined in the module's composer.jsonI added a test module repository at https://github.com/szeidler/drupal_tests_composer_patches . CircleCI: https://circleci.com/gh/szeidler/drupal_tests_composer_patches
I'm looking forward for your feedback.