-
Notifications
You must be signed in to change notification settings - Fork 9
Real composer patches format #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Real composer patches format #48
Conversation
|
||
// Use the old patch file standard in drupal_tests, which was independent | ||
// from any module composer.json patch specifications. | ||
$patches_file = 'patches.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for this, we can remove it when Drupal 8.7 or 8.8 is out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care. It follows only the default file name convention, not the old format. If the old/wrong composer patches format should be supported, we would need a different processing here.
templates/module/patches.json
Outdated
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline here.
Not sure why this failed, as you haven't touched this file. I'll take a look. |
Here's my initial work on making drupal_tests compatible with the correct composer-patches format, like reported in #47 .
Includes changes:
patches-file
in the modulepatches.json
like it was before, no matter if it was defined in the module's composer.jsonI added a test module repository at https://github.com/szeidler/drupal_tests_composer_patches . CircleCI: https://circleci.com/gh/szeidler/drupal_tests_composer_patches
I'm looking forward for your feedback.