Skip to content

Migrate Ahnlich DB to Grpc Implementation and Types #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Migrate Ahnlich DB to Grpc Implementation and Types #200

wants to merge 44 commits into from

Conversation

Iamdavidonuh
Copy link
Collaborator

No description provided.

deven96 and others added 14 commits February 22, 2025 19:03
@deven96 deven96 force-pushed the diretnan/grpc-migration-v2 branch from 86713ea to 2433929 Compare March 23, 2025 16:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.01    740.4±4.20µs        ? ?/sec    1.00   733.1±42.17µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.03      6.2±0.02ms        ? ?/sec    1.00      6.1±0.01ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.02     85.0±0.80ms        ? ?/sec    1.00     83.4±0.14ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.01    853.1±6.56ms        ? ?/sec    1.00    848.3±5.37ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.01      2.1±0.00ms        ? ?/sec    1.00      2.1±0.03ms        ? ?/sec
store_retrieval_no_condition/size_1000                       1.01     14.7±0.08ms        ? ?/sec    1.00     14.6±0.25ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.02    142.7±0.29ms        ? ?/sec    1.00    140.1±0.90ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.02   1431.0±2.04ms        ? ?/sec    1.00   1397.8±7.03ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.01      2.2±0.01ms        ? ?/sec    1.00      2.2±0.03ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     15.4±0.05ms        ? ?/sec    1.00     15.3±0.22ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.02    152.9±0.57ms        ? ?/sec    1.00    149.7±0.23ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.01   1535.4±1.97ms        ? ?/sec    1.00   1517.9±3.99ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.02   1513.8±3.09µs        ? ?/sec    1.00  1486.2±33.90µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.00     14.3±0.04ms        ? ?/sec    1.01     14.4±0.32ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.02    148.3±0.11ms        ? ?/sec    1.00    145.3±0.98ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.00   1456.4±0.24ms        ? ?/sec    1.00   1453.1±0.27ms        ? ?/sec

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

Test Results

147 tests   147 ✅  4m 14s ⏱️
  7 suites    0 💤
  2 files      0 ❌

Results for commit 8045850.

♻️ This comment has been updated with latest results.

deven96 and others added 17 commits April 26, 2025 02:27
@deven96
Migrating DSL to use grpc types
33ef906
@deven96
Ticked DSL task as done
13b9885
@Iamdavidonuh @deven96
David/grpc migration (#201)
c8c8917 
* Complete Fixmes in db

* port client db tests to grpc types

* port client ai tests to grpc types

* expect on server start on client db tests

* Select port for DB as the default is the same

* fxing test assertions for client

* Fix client db test assertions. Though it seems to be flaky when connecting to the db

* Fix typo

---------

Co-authored-by: Diretnan Domnan <[email protected]>
@Iamdavidonuh
More On Test Migrations (#202)
b35d889 
* WIP: ai_proxy tests migration

* Fix db_store_entry_to_store_get_key logic

* WIP: migrating AI tests.. 90%

* rewriting AI tests 99%

* fix error conversion for ahnlicherror

* fix persistence test error
@Iamdavidonuh
Update client docs and path to new ported clients
7d56ebd
@Iamdavidonuh
Rename grpc_types to types
e9d48e0
@Iamdavidonuh
More renaming from grpc_types to ahnlich_types
5c49da3
@Iamdavidonuh
Fix Ahnlich CLI
0d330a2
@Iamdavidonuh
Fix Rust Example
5744728
@Iamdavidonuh
Add lint directive for examples to workflow file
aace2b2
@Iamdavidonuh
Clippy fixes
5661f5c
@Iamdavidonuh
fixing path in action
d16c580
@Iamdavidonuh
fix failing tests and sort list stores res
f232b9f
@Iamdavidonuh
formatting similarity
595eca2
@Iamdavidonuh
fix tests in get key
2b4e72b
@Iamdavidonuh
fix tests in get key
5b24bb8
@deven96
Migrated python client to gRPC
8045850
@deven96 deven96 force-pushed the diretnan/grpc-migration-v2 branch from 249b5ba to 8045850 Compare May 30, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iamdavidonuh @deven96