Skip to content

fix(ui-library): icon size behaviour (798) #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix(ui-library): icon size behaviour (798) #969

merged 5 commits into from
Mar 4, 2024

Conversation

ChristianHoffmannS2
Copy link
Collaborator

No description provided.

davidken91
davidken91 previously approved these changes Feb 29, 2024
View reviewed changes
@ChristianHoffmannS2 ChristianHoffmannS2 linked an issue Feb 29, 2024 that may be closed by this pull request
Form Caption - icon in sm is not center aligned #798
Closed
5 tasks
JpunktWpunkt
JpunktWpunkt reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@JpunktWpunkt JpunktWpunkt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks, that the number input is a little bit broken now, same with the select, tab, text-input Component , also the icon page in storybook looks that the size has grown :)

@ChristianHoffmannS2
Copy link
Collaborator Author

It looks, that the number input is a little bit broken now, same with the select, tab, text-input Component , also the icon page in storybook looks that the size has grown :)

super, thanks!

well, the last one with the icons is fine for now, but the other ones should be addressed.

@ChristianHoffmannS2 ChristianHoffmannS2 merged commit 5f4c151 into develop Mar 4, 2024
@ChristianHoffmannS2 ChristianHoffmannS2 deleted the fix-icon-text-alignment-form-caption-798 branch March 4, 2024 15:48
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
@ChristianHoffmannS2
fix(ui-library): icon size behaviour (798) (#969)
665625a 
* fixed icon size behaviour

* fixed unit tests

* fix(ui-library): fixed default icon sizes settings for select, text/number input and tabbar
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
@ChristianHoffmannS2
fix(ui-library): icon size behaviour (798) (#969)
76506ea 
* fixed icon size behaviour

* fixed unit tests

* fix(ui-library): fixed default icon sizes settings for select, text/number input and tabbar
This was referenced Jan 6, 2025
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 13, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JpunktWpunkt JpunktWpunkt JpunktWpunkt approved these changes

@davidken91 davidken91 davidken91 approved these changes

@angsherpa456 angsherpa456 Awaiting requested review from angsherpa456

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form Caption - icon in sm is not center aligned
3 participants
@ChristianHoffmannS2 @JpunktWpunkt @davidken91