Skip to content

Render empty attributes as empty instead of "true" #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

vpzomtrrfrt
Copy link
Contributor

Seems to resolve #32

@developit developit merged commit 339888b into developit:master Feb 4, 2021
@developit
Copy link
Owner

Released in 2.1.1!

@rschristian
Copy link

Very late here, but this is a pretty big breaking change.

Take the following component, from Preact's docs site:

<logo height="1.5em" title="Preact" text inverted>Preact</logo>

With the following handling of props:

render({ inverted = false, text = false }) {

Probably a "damned if you do, damned if you don't" situation, but thought I'd at least comment on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<img alt="true" /> being set when alt="" is provided
3 participants