update common Gemfile for chef11+12 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the time being, we still have to support OS with legacy ruby, e.g. Ubuntu 12.04. So allow it to run all code correctly. Signed-off-by: Dominik Richter <[email protected]>
Unfortunately we have to disable it at this point, if we don't want to risk writing more functions to cover the same space. Even if the buildup structure of the hashmap is completely removed from these functions (thus reducing the total number of assignments considerably), we are left with a slightly over AbcSize for get_macs, which is due to the OS-checking inside. So ignore it unless we find a better solution Signed-off-by: Dominik Richter <[email protected]>
Closed
|
thanks for the lint improvements |
chris-rock
added a commit
that referenced
this pull request
May 12, 2015
update common Gemfile for chef11+12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.