fix: fix regression caused by join on trials view

[salonig23]

Description

Join on trials view was causing regression, and slowing down GetExperiments. Fixed it by removing join and adding column to runs table.

Test Plan

Make sure all tests pass

For CLI -
Experiment:

1. Create an experiment.
2. Wait for the experiment to complete.
3. Run det e set log-retention-days <exp-id> --days 50
4. Check the runs table in the database to see if the associated trials for the experiment have updated the log retention days to 50.
5. Run det e set log-retention-days <exp-id> --days none --forever
6. Check the tasks table in the database to see if the associated trials for the experiment have updated the log retention days to -1.

Trial:

1. Create an experiment.
2. Wait for the experiment to complete.
3. Run det t set log-retention-days <trial-id> --days 50 for any trial in the experiment.
4. Check the runs table in the database to see if the trial has updated the log retention days to 50.
5. Run det t set log-retention-days <trial-id> --days none --forever
6. Check the tasks table in the database to see if the trial has updated the log retention days to -1.

For API -

1. Create an experiment.
2. Wait for the experiment to complete.
3. Use the following API endpoint:

curl -X 'PUT'
'http://localhost:8080/api/v1/experiments/1/retain_logs'
-H 'accept: application/json'
-H 'Content-Type: application/json'
-d '{
"experimentId": 1,
"numDays": 40
}'

Check the tasks table in the database to see if the associated trials for the experiment have updated the log retention days to 40.

curl -X 'PUT'
'http://localhost:8080/api/v1/trials/1/retain_logs'
-H 'accept: application/json'
-H 'Content-Type: application/json'
-d '{
"trialId": 1,
"numDays": -1
}'

Check the tasks table in the database to see if the trial has updated the log retention days to -1.

For WebUI -

1. Create a few experiments.
2. Go to the Experiments list in the Web UI and select a few of them and then click on the actions button.
   
3. Select the Retain Logs option from the drop down.
4. Type any number in the Number of days field when prompted.
5. Wait for a success message.
6. Check the runs table in the database to see if the associated trials for the experiment have updated the log retention days to the number you put in.
7. Select a few more experiments and follow the above steps, but this time click on the 'Forever' checkbox instead.
8. Wait for a success message.
9. Check the runs table in the database to see if the associated trials for the experiment have updated the log retention days to -1.
10. Also check the Trial List Table to see if the Log Retention Days Column shows up and has the correct days.

Commentary (optional)

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

[netlify]

✅ Deploy Preview for determined-ui canceled.

Name	Link
🔨 Latest commit	15fa3eb
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66104964817d680008645eb1

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 46.67%. Comparing base (f4b0471) to head (15fa3eb).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9091      +/-   ##
==========================================
+ Coverage   46.65%   46.67%   +0.01%     
==========================================
  Files        1172     1172              
  Lines      143621   143617       -4     
  Branches     2409     2410       +1     
==========================================
+ Hits        67013    67028      +15     
+ Misses      76403    76384      -19     
  Partials      205      205              

Flag	Coverage Δ
backend	43.48% <66.66%> (+0.03%)	⬆️
harness	63.99% <ø> (ø)
web	37.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
master/internal/checkpoint_gc.go	65.93% <100.00%> (-0.38%)	⬇️
master/internal/command/command.go	67.82% <100.00%> (-0.14%)	⬇️
master/internal/db/postgres_tasks.go	69.11% <100.00%> (-0.12%)	⬇️
master/internal/logretention/logretention.go	84.90% <100.00%> (+0.59%)	⬆️
master/internal/trial.go	41.58% <100.00%> (-0.12%)	⬇️
master/pkg/model/experiment.go	14.28% <100.00%> (+0.35%)	⬆️
master/pkg/model/task.go	15.26% <ø> (ø)
master/internal/api_trials.go	54.69% <80.00%> (+1.32%)	⬆️
master/internal/experiment/bulk_action.go	0.00% <0.00%> (ø)
master/internal/populate_metrics.go	0.00% <0.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

[NicholasBlaskey]

Looks good to me

I would check the performance test run first and get someone who has more context on this project to make sure it makes sense to have it on both tasks and runs

[NicholasBlaskey]

LGTM but I would get @erikwilson to make sure the design look right since I'm not familiar with this feature

[NicholasBlaskey]

is this set or returned anywhere?

[salonig23]

actually, I don't think so. i'll remove it