-
Notifications
You must be signed in to change notification settings - Fork 365
chore: OSS -> EE mass migration #9086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c1c6148
to
1af51a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9086 +/- ##
=======================================
Coverage 46.16% 46.17%
=======================================
Files 1174 1174
Lines 145186 145186
Branches 2413 2413
=======================================
+ Hits 67026 67035 +9
+ Misses 77952 77943 -9
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. |
1af51a7
to
91227ca
Compare
c49d7a1
to
0f8caff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine from infra review perspective. This seems like the type of change where testing will be the best way to find problems and it looks like that happened.
Description
Before merging EE and OSS, we must bring both migrations to parity. The up migration in this PR contain all the migrations that OSS is missing while remaining a no-op for EE databases. In addition, we are adding all the down migrations corresponding with the ones included in the up migration, just in case someone wants to do a down migration.
Test Plan
Make sure CI is running fine.
To manually test, remove
oss-to-ee-catch-up.tx.up.sql
from the migrations directory and run devcluster with a clean database. Then add the file back and restart devcluster master. This should succeed. Next, switch to EE version and run devcluster (without removing the database). The upgrade from OSS to EE should be seamless.Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket