-
Notifications
You must be signed in to change notification settings - Fork 3
결과 페이지 질문 변경 #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
결과 페이지 질문 변경 #135
Conversation
Bundle SizesCompared against dab8a22
Dynamic import: None found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 components
하위에 있는 컴포넌트들은 커먼하게 쓰일 수 있는 것들을 모아두는 용으로 생각하고 있었어요!
사용하시는 feature에 BottomSheet 컴포넌트를 사용하는 새로운 컴포넌트로 대응하는 것은 어떨까요 ??
CI 깨지는 건 바텀시트 컴포넌트 변경 때문에 그렇네요 !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BottomSheet는 타겟 질문폼 생성 플로우에서도 사용이 되서,
BottomSheet를 import 해서 사용해주시면 좋을 것 같아요!
잘 안보이지만, 질문 폼 생성 부분이 자세히~~ 보면 바텀시트입니다!
아핫 그렇군요!! 바꿔놓겠습니당 감사합니다~~! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 32 32
Lines 210 210
Branches 41 41
=======================================
Hits 201 201
Misses 9 9
☔ View full report in Codecov by Sentry. |
Deploying with
|
Latest commit: |
9325d7b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9518cd82.na-lab.pages.dev |
Branch Preview URL: | https://feat-question-list.na-lab.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
🙏 여기는 꼭 봐주세요!
🌄 스크린샷