Skip to content

결과 페이지 질문 변경 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2023
Merged

결과 페이지 질문 변경 #135

merged 4 commits into from
May 23, 2023

Conversation

oyeon-kwon
Copy link
Collaborator

🙏 여기는 꼭 봐주세요!

  • 바텀시트를 쓰는 곳이 여기밖에 안보여서 바텀시트에 작업했는데.. 괜찮을까요,.?

🌄 스크린샷

스크린샷 2023-05-23 오전 12 48 49

@oyeon-kwon oyeon-kwon self-assigned this May 22, 2023
@github-actions
Copy link

github-actions bot commented May 22, 2023

Bundle Sizes

Compared against dab8a22

Route Size (gzipped) Diff
/ 78.82 KB +6.43 KB

Dynamic import: None found.

Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 components 하위에 있는 컴포넌트들은 커먼하게 쓰일 수 있는 것들을 모아두는 용으로 생각하고 있었어요!

사용하시는 feature에 BottomSheet 컴포넌트를 사용하는 새로운 컴포넌트로 대응하는 것은 어떨까요 ??

@hyesungoh
Copy link
Member

hyesungoh commented May 22, 2023

CI 깨지는 건 바텀시트 컴포넌트 변경 때문에 그렇네요 !!

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BottomSheet는 타겟 질문폼 생성 플로우에서도 사용이 되서,
BottomSheet를 import 해서 사용해주시면 좋을 것 같아요!

잘 안보이지만, 질문 폼 생성 부분이 자세히~~ 보면 바텀시트입니다!

@oyeon-kwon
Copy link
Collaborator Author

아핫 그렇군요!! 바꿔놓겠습니당 감사합니다~~!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (340b56e) 95.71% compared to head (9325d7b) 95.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          32       32           
  Lines         210      210           
  Branches       41       41           
=======================================
  Hits          201      201           
  Misses          9        9           
Impacted Files Coverage Δ
src/components/bottomSheet/BottomSheet.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9325d7b
Status: ✅  Deploy successful!
Preview URL: https://9518cd82.na-lab.pages.dev
Branch Preview URL: https://feat-question-list.na-lab.pages.dev

View logs

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oyeon-kwon oyeon-kwon merged commit 53b516b into main May 23, 2023
@oyeon-kwon oyeon-kwon deleted the feat/question-list branch May 23, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants