[DPMBE-68] 유저 프로필 이미지 업로드 기능을 만든다 #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
ImNM
approved these changes
Jun 15, 2023
|
버킷이 환경변수여서 버킷별로 구분하면 될거같아요! |
BlackBean99
approved these changes
Jun 16, 2023
Comment on lines
+38
to
+61
| companion object { | ||
| fun createForPromise(userId: Long, promiseId: Long, url: String, uuid: String, pictureCommentType: PictureCommentType): Picture { | ||
| return Picture( | ||
| userId = userId, | ||
| promiseId = promiseId, | ||
| url = url, | ||
| uuid = uuid, | ||
| pictureType = PictureType.PROMISE, | ||
| pictureCommentType = pictureCommentType, | ||
| ) | ||
| } | ||
|
|
||
| fun createForUser(userId: Long, url: String, uuid: String): Picture { | ||
| return Picture( | ||
| userId = userId, | ||
| promiseId = 0, | ||
| url = url, | ||
| uuid = uuid, | ||
| pictureType = PictureType.USER, | ||
| pictureCommentType = PictureCommentType.NONE, | ||
| ) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
동행객체로 따로 빼는군요 왜 그런건가요? 궁금
There was a problem hiding this comment.
static 코틀린에서는 못만들어서 class 안에서 선언할 떄 저렇게 선언하는건데용
Picture 생성하는거 펙토리 메소드로 뺀거죠?
Comment on lines
+3
to
+5
| enum class PictureType { | ||
| PROMISE, USER | ||
| } |
There was a problem hiding this comment.
일단 인터랙션은 프론트에서 따로 하니까 미디어로 2가지로만 한거죠?
kdomo
added a commit
that referenced
this pull request
Jun 16, 2023
* feat: 유저 프로필 presignedUrl 발급 기능 추가 * test: 유저 프로필 presignedUrl 발급 기능 테스트 코드 추가 * feat: 유저 프로필 업로드 성공 확인 기능 추가 * test: 유저 프로필 업로드 성공 확인 기능 테스트 코드 추가 * style: spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직