Skip to content

[DPMBE-117] notification 테이블을 상속 구조로 리팩터링 한다 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2023
Merged

[DPMBE-117] notification 테이블을 상속 구조로 리팩터링 한다 #198

merged 4 commits into from
Jul 15, 2023

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jul 15, 2023 •
edited
Loading

개요

작업사항

  • notification 부분 확장성있게 상속 구조로 변경하고,
  • 이벤트 핸들러들 패키지가 다른게 있어서 수정하고,
  • 똑같은 이벤트인데 핸들러 두개로 나눠져있는거 하나로 통합했습니다.

@kdomo kdomo self-assigned this Jul 15, 2023
@kdomo kdomo requested review from ImNM and BlackBean99 as code owners July 15, 2023 06:15
ImNM
ImNM approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.1% 14.1% Coverage
0.0% 0.0% Duplication

@kdomo kdomo merged commit 251afe6 into develop Jul 15, 2023
@kdomo kdomo deleted the feature/DPMBE-117 branch July 15, 2023 06:45
BlackBean99 pushed a commit that referenced this pull request Jul 17, 2023
@kdomo @BlackBean99
[DPMBE-117] notification 테이블을 상속 구조로 리팩터링 한다 (#198)
80dc052 
* refactor: notification 테이블을 상속 구조로 리팩터링 한다

* move: handler 클래스 패키지 이동

* refactor: 동일 이벤트에 대해 이벤트 핸들러 통합

* style: 주석제거
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImNM ImNM ImNM approved these changes

@BlackBean99 BlackBean99 BlackBean99 approved these changes

Assignees

@kdomo kdomo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DPMBE-117] notification 테이블을 상속구조로 리팩터링한다
3 participants
@kdomo @ImNM @BlackBean99