Skip to content

[DPMBE-100] 약속 이미지에 Coordainate(위경도)를 제거한다 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2023
Merged

[DPMBE-100] 약속 이미지에 Coordainate(위경도)를 제거한다 #151

merged 3 commits into from
Jul 7, 2023

Conversation

kdomo
Copy link
Member

@kdomo kdomo commented Jul 6, 2023

개요

작업사항

  • 이미지를 좌표 상 위치에 고정시켜놓는줄 알고 위치값을 받았는데, 유저 위치에 따라 핀 대신 이미지로 바뀌는 거였네용

변경로직

  • 내용을 적어주세요.

@kdomo kdomo requested review from ImNM and BlackBean99 as code owners July 6, 2023 06:40
@kdomo kdomo self-assigned this Jul 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

BlackBean99
BlackBean99 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@BlackBean99 BlackBean99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 생각보다 연결된게 엄청 많았네요 수고했어요

ImNM
ImNM approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@kdomo kdomo merged commit fb3b225 into develop Jul 7, 2023
@kdomo kdomo deleted the feature/DPMBE-100 branch July 7, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImNM ImNM ImNM approved these changes

@BlackBean99 BlackBean99 BlackBean99 approved these changes

Assignees

@kdomo kdomo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DPMBE-100] 약속 이미지에 Coordainate(위경도)를 제거한다
3 participants
@kdomo @ImNM @BlackBean99