[DEMBE-90] 약속에 참여한 유저의 인터렉션 정보를 약속 모음집 상세 응답값에 추가한다 #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
BlackBean99
approved these changes
Jul 6, 2023
Comment on lines
119
to
120
| val promiseUserInfoVos = promiseUsers.mapNotNull { promiseUser -> | ||
| val user = users.find { it.id == promiseUser.userId } |
There was a problem hiding this comment.
promiseUser-> 를 썼는데 it 을 쓰는게 상관은 없지만 맥락상 통일하는게 좋지 않을까요?
Comment on lines
109
to
+112
| Mockito.`when`(promiseUserAdaptor.findByUserId(userId)).thenReturn(promiseUsers) | ||
| Mockito.`when`(promiseAdaptor.queryPromises(listOf(1, 2))).thenReturn(promises) | ||
| Mockito.`when`(userAdapter.queryUsers(listOf(1))).thenReturn(users) | ||
| Mockito.`when`(interactionAdapter.queryAllInteraction(1, 1)).thenReturn(interactions) |
There was a problem hiding this comment.
import 해서 Mockito 를 빼도 좋을 것 같아요! 본인 선택!
There was a problem hiding this comment.
저기 모두 서현님이 짜신 코드인데 제가 변경할까용?
따로 안건들이긴 했습니당😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항