Bundler: Convert FileParser specs to projects #3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are a couple spec failures and seeing this in the error output |
feelepxyz
reviewed
Feb 24, 2021
| end | ||
| let(:gemfile_fixture_name) { "version_specified" } | ||
| let(:lockfile_fixture_name) { "bundler_2.lock" } | ||
| let(:dependency_files) { project_dependency_files("bundler1/version_specified_bundler_2") } |
There was a problem hiding this comment.
Not for now but adding a mental note to go through fixtures once we add support for bundler 2 and move to bundler2/..
feelepxyz
reviewed
Feb 24, 2021
| support_file: true | ||
| ) | ||
| end | ||
| let(:dependency_files) { project_dependency_files("bundler1/version_specified_gemfile_specification") } |
There was a problem hiding this comment.
does this not need the same support_file = true setup?
There was a problem hiding this comment.
It might? I thought all tests were passing locally but it seems I may have missed one or two, this might be one of them!
feelepxyz
reviewed
Feb 24, 2021
feelepxyz
approved these changes
Feb 24, 2021
jurre
force-pushed
the
jurre/bundler-file-parser-spec-projects
branch
from
fa7099a to
9e6a356
Compare
Mostly using #3027 with some manual fixing afterwards.
jurre
force-pushed
the
jurre/bundler-file-parser-spec-projects
branch
from
9e6a356 to
5ca6f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly using #3027
with some manual fixing afterwards.