-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Engines package.json: support special characters >=, ~, ^ (npm_and_yarn) #12648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ea5d97a
to
64840ec
Compare
Hi @fallemand 👋🏻 , thank you for the PR!! , we will triage this asap for review and deploy. |
5e8fdf2
to
7fb335d
Compare
@sachin-sandhu After pulling EDIT: Here is the smoke tests update PR |
@sachin-sandhu any hope? |
@fallemand what about this scenario? {
"pnpm": "^10.11"
} If you just remove the character, then the version needed must be 10.11 but that's not the intent and it will probably fail as well because that might not be the same that is installed in Dependabot. Shouldn't you be using a semver library to extract the major version(s)? |
What are you trying to accomplish?
The following syntax from the
engines
field in thepackage.json
are not supported:>=
,~
,^
, and they are valid.How will you know you've accomplished your goal?
This will solve the issue: #12643
Checklist