Support both the internal and external representation for the update config function #12344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeikel
force-pushed
the
support-two-way-config-input
branch
from
16b73cb to
016de36
Compare
yeikel
commented
May 30, 2025
| inverted = PACKAGE_MANAGER_LOOKUP.invert | ||
| package_ecosystem = inverted[package_manager] || PACKAGE_MANAGER_LOOKUP[package_manager] | ||
| if package_ecosystem.nil? | ||
| inverted.fetch(package_manager) # throws KeyError |
There was a problem hiding this comment.
Keep for backwards compatibility with existing usage
yeikel
force-pushed
the
support-two-way-config-input
branch
4 times, most recently
from
b1a98f1 to
74ec8c2
Compare
|
@sachin-sandhu Any chance you can help me find a reviewer for this change? |
…config function Enhances the `update_config` function by allowing it to support both internal and external representations of package ecosystem names. For example, `github_actions` (internal) and `github-actions` (external) are now both recognized, improving compatibility and flexibility when parsing configuration files.
yeikel
force-pushed
the
support-two-way-config-input
branch
from
74ec8c2 to
09f7448
Compare
|
@yeikel , thank you for your contribution! we will triage the PR for review, we will keep you updated on any new updates. |
|
Hi @yeikel 👋🏻 , Apologies for late communication, We discussed the proposed change with the team internally in detail. Dependabot team thanks you for your contribution and your unparalleled effort in improving dependabot. To make it work consistently across board (advisory db and api), we would also need to make additional changes which are out of scope of current work. We are not going ahead with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Enhances the
update_configfunction by allowing it to support both internal and external representations of package ecosystem names.For example,
github_actions(internal) andgithub-actions(external) are now both recognized, improving compatibility and flexibility when parsing configuration files.Anything you want to highlight for special attention from reviewers?
I discovered this small annoyance while trying to call the
update_configfrom a library. I suspect that other users of this API may need to keep a similar map to use this featureHow will you know you've accomplished your goal?
Using the existing and updated tests cases
Checklist