Skip to content

Adds cooldown options for go_modules #12119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2025
Merged

Adds cooldown options for go_modules #12119

merged 3 commits into from
Apr 26, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Apr 22, 2025 •
edited
Loading

What are you trying to accomplish?

Part of adding cooldown options to go_modules

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Apr 22, 2025
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner April 22, 2025 20:00
@github-actions github-actions bot added the L: go:modules Golang modules label Apr 22, 2025
@sachin-sandhu sachin-sandhu marked this pull request as draft April 22, 2025 20:03
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/go-modules-cooldown-options branch from ab1fe35 to fbe8929 Compare April 22, 2025 20:08
@sachin-sandhu sachin-sandhu marked this pull request as ready for review April 22, 2025 20:31
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/go-modules-cooldown-options branch from fbe8929 to ee77d04 Compare April 22, 2025 20:57
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/go-modules-cooldown-options branch 3 times, most recently from 6ff37e3 to c268899 Compare April 25, 2025 02:37
@sachin-sandhu sachin-sandhu changed the title adds cooldown options for go_modules Adds cooldown options for go_modules Apr 25, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/go-modules-cooldown-options branch from c268899 to 0a75868 Compare April 25, 2025 02:48
@sachin-sandhu sachin-sandhu requested a review from kbukum1 April 25, 2025 15:51
kbukum1
kbukum1 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/go-modules-cooldown-options branch from 0a75868 to 6b7c36b Compare April 25, 2025 23:56
@sachin-sandhu sachin-sandhu merged commit 19ee683 into main Apr 26, 2025
74 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/go-modules-cooldown-options branch April 26, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbukum1 kbukum1 kbukum1 approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: go:modules Golang modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-sandhu @kbukum1