write user-level NuGet.Config in end-to-end updater
#12105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for `replaces-base`
brettfo
commented
Apr 21, 2025
| @@ -32,7 +31,7 @@ public sealed record Job | |||
| public bool RejectExternalCode { get; init; } = false; | |||
| public bool RepoPrivate { get; init; } = false; | |||
| public CommitOptions? CommitMessageOptions { get; init; } = null; | |||
| public ImmutableArray<Dictionary<string, string>>? CredentialsMetadata { get; init; } = null; | |||
| public ImmutableArray<Dictionary<string, object>>? CredentialsMetadata { get; init; } = null; | |||
There was a problem hiding this comment.
The native updater doesn't use these values so object is fine.
sebasgomez238
approved these changes
Apr 23, 2025
phillipuniverse
pushed a commit
to phillipuniverse/dependabot-core
that referenced
this pull request
Apr 29, 2025
Also adds support for `replaces-base` Co-authored-by: Abhishek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the end-to-end updater with support for writing a user-level
NuGet.Configwith the feed credentials that were passed in via the job file ordependabot.yml. This behavior already exists in the hybrid Ruby/C# updater.The end-to-end updater also now has support for the
replaces-baseparameter which is used to suppress the default package feed; in this caseapi.nuget.org.All relevant implementation and testing is done in the PowerShell scripts with only a single change in the C# code to allow the contents of
credentials-metadatato be anything (object) instead ofstring. The native updater doesn't use those values so the type is irrelevant.No tokens or passwords are written to the user-level
NuGet.Configfile; the proxy handles all of that for us.Fixes #11781