Skip to content
This repository was archived by the owner on Jun 29, 2023. It is now read-only.

Change registry menu to horizontal #195

Merged
merged 5 commits into from
Jan 20, 2020
Merged

Change registry menu to horizontal #195

merged 5 commits into from
Jan 20, 2020

Conversation

fakoua
Copy link
Contributor

@fakoua fakoua commented Jan 19, 2020

This is the PR1 to change the registry menu to Horizontal,
Once merged I will PR the case sensitive issue.
Thanks

ry
ry reviewed Jan 19, 2020
View reviewed changes
@ry
Copy link
Member

ry commented Jan 19, 2020 •
edited
Loading

@fakoua I agree to the look of it, but I want the website to avoid custom styles and complex UI as much as possible. I don't like all the CSS needed to make Divider work... Rather we should find some material UI that just works without customization. I've replaced your work with a Button. What do you think?

Screen Shot 2020-01-19 at 2 42 23 PM

@fakoua
Copy link
Contributor Author

fakoua commented Jan 19, 2020

Hi,
Looks fine, but it gives the impression of a button not a link or menu.
Frankly speaking, I liked the first one with pipe, however it's up to you, let me know if you want me to implement your design.

@ry
Copy link
Member

ry commented Jan 19, 2020

I prefer the pipe too, but I want to keep within the material UI design....

@fakoua
Copy link
Contributor Author

fakoua commented Jan 19, 2020

OK, tomorrow will try my best to check the material ui site.

@fakoua
Copy link
Contributor Author

fakoua commented Jan 20, 2020 •
edited
Loading

@ry Now im using ButtonGroup pure material UI without styles,
Please review the new design,
Change already PR-ed
d02

ry
ry approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit f10aa66 into denoland:master Jan 20, 2020
@kitsonk kitsonk mentioned this pull request May 31, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fakoua @ry