-
Notifications
You must be signed in to change notification settings - Fork 45
refactor: check assertions per import statement #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 12 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
23bde67
refactor: check assertions per import statement
nayeemrmn 0af4881
fmt
nayeemrmn af1009e
review
nayeemrmn e964794
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn d9d9c70
add comment for is_known_none()
nayeemrmn e8e71af
move dynamic import skip to validate()
nayeemrmn 33cd066
use follow_dynamic
nayeemrmn 8b55dff
better serialization for import assertions
nayeemrmn bae5aa5
populate module_metadata in fill()
nayeemrmn 734fba4
remove unnecessary types / trait impls
nayeemrmn a3042b9
change ModuleGraphError::UnsupportedMediaType to unnamed tuple fields
nayeemrmn c625c53
collapse ModuleGraphError::ModuleError()
nayeemrmn 7901e8c
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn fc487c5
remove ModuleKind::Asserted
nayeemrmn 908cd6d
add ImportKind
nayeemrmn 6750bb0
skip serializing ImportKind::Es
nayeemrmn 604376c
fix: use same behaviour if has resolver or not
dsherret be06539
Move invalid local import checks to validate
dsherret 0e8b76a
Test.
dsherret 1ad47ec
Wasm
dsherret 4db3546
Merge my work on main
dsherret 637de8e
Merge branch 'main' into import-errors
dsherret b3a1998
Update wasm
dsherret ccb15a9
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn e386130
only enforce assertions on es runtime imports
nayeemrmn bfb545e
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn edbf9a3
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn 6e68504
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn 0171ce5
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn 47ff14d
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn 792196e
Merge remote-tracking branch 'upstream/main' into import-errors
nayeemrmn 205b21e
don't serialize assertions, maybe unstable
nayeemrmn 4b65693
restore Dependency::assertionType for legacy
nayeemrmn 03f670c
fixup! restore Dependency::assertionType for legacy
nayeemrmn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.