Skip to content

chore(std): Remove tsconfig_test.json #8629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2020
Merged

chore(std): Remove tsconfig_test.json #8629

merged 3 commits into from
Dec 7, 2020

Conversation

nayeemrmn
Copy link
Contributor

Missed in #8050. Also updates doc surrounding isolatedModules and --no-check.

@bartlomieju bartlomieju requested a review from kitsonk December 6, 2020 12:47
bartlomieju
bartlomieju reviewed Dec 6, 2020
View reviewed changes
docs/getting_started/typescript.md Outdated
Comment on lines 30 to 32
value) or removed (in case `Foo` is strictly a type) in the output JS. So Deno
_without_ `--no-check` requires that all TS complies with
[`isolatedModules`](https://www.typescriptlang.org/tsconfig#isolatedModules)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think isolatedModules is required even with type checking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think isolatedModules is required even with type checking?

Yes I wrote "without --no-check". In fact it's only required with type checking, but that makes it --no-check compatible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayeemrmn I see; I'm concerned about wording here - it suggests that isolatedModules is required only in a specific scenario while in fact it's always required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole TypeScript section needs to be re-written. It is on my back burner under #8139. I think what is there could be a bit confusing, but is accurate and sufficient for the time being.

kitsonk
kitsonk approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit b77d6cb into denoland:master Dec 7, 2020
@nayeemrmn nayeemrmn deleted the std-tsconfig-test branch December 7, 2020 20:51
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@nayeemrmn
chore(std): Remove tsconfig_test.json (denoland/deno#8629)
c85f697 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn
chore: Remove tsconfig_test.json (denoland/deno#8629)
6c41058 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
chore: Remove tsconfig_test.json (denoland/deno#8629)
4caa986 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
chore: Remove tsconfig_test.json (denoland/deno#8629)
94181e6 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
chore: Remove tsconfig_test.json (denoland/deno#8629)
3878cd4 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
chore: Remove tsconfig_test.json (denoland/deno#8629)
6e58e21 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
chore: Remove tsconfig_test.json (denoland/deno#8629)
443ceb8 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @denobot
chore: Remove tsconfig_test.json (denoland/deno#8629)
3444722 
Ref denoland/deno#8050
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@nayeemrmn @denobot
chore: Remove tsconfig_test.json (denoland/deno#8629)
e90ccdb 
Ref denoland/deno#8050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayeemrmn @kitsonk @bartlomieju