Skip to content

fix(cli): allow remapping to locals for import map #8262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2020
Merged

fix(cli): allow remapping to locals for import map #8262

merged 1 commit into from
Nov 7, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 6, 2020

Fixes #7723

@kitsonk kitsonk requested a review from bartlomieju November 6, 2020 04:53
@kitsonk
Copy link
Contributor Author

kitsonk commented Nov 6, 2020

Not really sure if this is a fix or a feature. 🤷

bartlomieju
bartlomieju approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can qualify it as a fix :)

@kitsonk kitsonk merged commit 88c4d31 into denoland:master Nov 7, 2020
@kitsonk kitsonk deleted the fix-7723 branch November 7, 2020 04:04
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
@kitsonk @jannes
fix(cli): allow remapping to locals for import map (denoland#8262)
c2eede2 
Fixes denoland#7723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot remap a transitive dependency to a local file
2 participants
@kitsonk @bartlomieju