Skip to content

refactor(cli): move bundle check to new infrastructure #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

refactor(cli): move bundle check to new infrastructure #8071

merged 1 commit into from
Oct 23, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 22, 2020

Currently builds on #7996, will rebase once that is landed.

@kitsonk kitsonk changed the title [WIP] refactor(cli): move bundle check to new infrastructure refactor(cli): move bundle check to new infrastructure Oct 23, 2020
@kitsonk kitsonk marked this pull request as ready for review October 23, 2020 01:17
@kitsonk kitsonk requested a review from bartlomieju October 23, 2020 10:57
bartlomieju
bartlomieju approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice code removal

@kitsonk kitsonk merged commit ab89855 into denoland:master Oct 23, 2020
This was referenced Oct 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsonk @bartlomieju