-
Notifications
You must be signed in to change notification settings - Fork 5.6k
test: add proxy tests #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add proxy tests #2977
Conversation
For convenience we should also support |
691aab2
to
d66babb
Compare
🎉 CC @ry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! It's great to have this nailed down.
At the end of the CLI help text, there are some env vars listed, can you add HTTP_PROXY there:
> deno --help
[ ... ]
ENVIRONMENT VARIABLES:
DENO_DIR Set deno's base directory
NO_COLOR Set to disable color
Oh yes, forgot about that. I'll update the PR shortly |
@ry this should be ready now. Unfortunately tests fail on Windows if I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #2873
http
fetch
manual.html
EDIT:
I removed todo to test
https
proxy as we don't supporthttps
very well indeno_std
server.Eg, for example proxying request to `https://deno.land/welcome.ts:
We should be proxying to
https://deno.land/welcome.ts
but we receivedeno.land:443
url inServerRequest
. Correct me if I'm wrong and it can be somehow done