Skip to content

fix(bench): lower bench time budget when n is specified #28454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dsherret
Copy link
Member

Closes #28430

@dsherret dsherret requested a review from nathanwhit March 10, 2025 17:49
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit ff28ecd into denoland:main Mar 10, 2025
18 checks passed
@dsherret dsherret deleted the fix_lower_bench_time_budget_n_specified branch March 10, 2025 20:17
ry pushed a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno bench ignores n and warmupoptions when code being benched is too quick
2 participants