Skip to content

fix(publish): support jsx/tsx #28188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 20, 2025
Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 19, 2025

@dsherret dsherret marked this pull request as ready for review February 19, 2025 23:52
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, exciting!

Comment on lines +153 to +158
static JSX_RUNTIME_RE: Lazy<regex::Regex> =
lazy_regex::lazy_regex!(r"(?i)^[\s*]*@jsxRuntime\s+(\S+)");
static JSX_FACTORY_RE: Lazy<regex::Regex> =
lazy_regex::lazy_regex!(r"(?i)^[\s*]*@jsxFactory\s+(\S+)");
static JSX_FRAGMENT_FACTORY_RE: Lazy<regex::Regex> =
lazy_regex::lazy_regex!(r"(?i)^[\s*]*@jsxFragmentFactory\s+(\S+)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already had these defined somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherret dsherret enabled auto-merge (squash) February 20, 2025 22:25
@dsherret dsherret merged commit 4523ddd into denoland:main Feb 20, 2025
18 checks passed
@bartlomieju bartlomieju deleted the feat_jsx_jsr_support branch February 20, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants