Skip to content

fix(node:sqlite): Fix Named parameters #28154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

dovakin0007
Copy link
Contributor

@dovakin0007 dovakin0007 commented Feb 17, 2025

This PR introduces support for named parameters in SQLite queries, as outlined in #28134

image

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Is this ready for review?

@dovakin0007
Copy link
Contributor Author

Thanks for the PR. Is this ready for review?

not yet still working on a small change. thank you!

@dovakin0007 dovakin0007 marked this pull request as ready for review February 18, 2025 13:40
@dovakin0007
Copy link
Contributor Author

Thanks for the PR. Is this ready for review?

it's ready now thanks for the change it fixed a bug I was encountering

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 9b9eeab into denoland:main Feb 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants